Rust: Basic support for future content and .await
#18685
Merged
+226
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
rust-future-content
branch
from
92b4a63 to
6e99087
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
geoffw0
reviewed
Feb 11, 2025
| @@ -203,6 +203,16 @@ fn test_apply_flow_through() { | |||
| sink(t); // $ hasValueFlow=33 | |||
| } | |||
|
|
|||
| async fn get_async_number(a: i64) -> i64 { | |||
| 37 | |||
| } | |||
There was a problem hiding this comment.
It would be nice to have a comment that this function has a summary model with taint through it.
There was a problem hiding this comment.
Makes sense. Done :)
geoffw0
previously approved these changes
Feb 11, 2025
paldepind
force-pushed
the
rust-future-content
branch
from
928f72d to
efb5b9b
Compare
|
I had forgotten to update the |
geoffw0
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a small step towards handling async Rust:
Futuretrait..awaitreads from the future content.Notably this doesn't handle non-modeled calls to
asyncfunctions.